Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to parking values and reorder them #1402

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Nekzuris
Copy link
Contributor

@Nekzuris Nekzuris commented Dec 8, 2024

Description, Motivation & Context

Following @tordans suggestion in #1326 (comment), I added descriptions to parking values and reordered them according to taginfo usage while keeping similar values together, like street_side/lane and multi-storey/rooftop.

Related issues

#1325 #1326

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

https://taginfo.openstreetmap.org/keys/parking#values

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

github-actions bot commented Dec 8, 2024

🍱 You can preview the tagging presets of this pull request here.

@Nekzuris
Copy link
Contributor Author

Nekzuris commented Dec 8, 2024

Test-Documentation

Preview links & Sidebar Screenshots

before vs after preview
beforeafter

Wording

  • American English

@tordans tordans merged commit 5f054c9 into openstreetmap:main Dec 19, 2024
5 checks passed
@tordans tordans added the field label Dec 19, 2024
@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

Nice, thanks! Now we need to find a way to make those descriptions easier to see in iD, but that is a different story :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants